Repository navigation
fix(milestones): a milestone can pay out more than its first issue - #675
Open
yggdrasilworld wants to merge 1 commit into
Open
yggdrasilworld wants to merge 1 commit into
yggdrasilworld wants to merge 1 commit into
Conversation
|
@yggdrasilworld is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Scope audit addendum: implemented the AC's actual contract — explicit status check (FUNDED | IN_PROGRESS) throwing 'not accepting distributions', assertTransition only when the status really changes. Added the demanded two-resolutions-in-a-row test. Repaired upstream drift blocking the suite (escrow.service merge-tangle, sponsor-binding caller, releasePartial 5-arg). jest 20/20. |
…ft (MergeFi#578) resolveIssue's bare assertTransition made IN_PROGRESS -> IN_PROGRESS fail, so a milestone could only ever pay its first issue. The status check (FUNDED | IN_PROGRESS) gives callers a clean 400 and the state machine only runs when the status actually changes. Adds the demanded two-resolutions-in-a-row test; updates the controller spec for the server-side user derivation + IdempotencyInterceptor DI upstream now requires.
yggdrasilworld
force-pushed
the
fix/milestone-multi-issue-578
branch
from
October 16, 2026 16:46
f7150f8 to
6106dc2
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
resolveIssueassertedstatus->IN_PROGRESSon every call — the first resolve moved FUNDED->IN_PROGRESS, so the second hit IN_PROGRESS->IN_PROGRESS (invalid) and threw. A milestone could only ever pay ONE issue.Fix
Only transition when not already IN_PROGRESS.
Resolves #578
Payment: Base USDC
0xD40Df5c27cEa7dd78A3c345401995c319589334e